fix: file ownership of files copied into the container #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll rebase this on main, now that #2005 is in |
Revert to using `cat`/`tar` to copy files/folders into the container.
|
Why still draft? Is there something left? |
|
I don't think so. I suspect it was set to draft while we were deciding between this and #2006 . |
|
Ah, okay |
|
Thanks for the RtD fix - looks like my rebase missed it by seconds! nvm, we can ignore that failure. |
henryiii
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert to using
cat/tarto copy files/folders into the container.Alternative to #2006
Fix #2004
Based on #2005