Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manylinux2010-i686 docker image #355

Merged
merged 1 commit into from
Oct 8, 2019
Merged

Add manylinux2010-i686 docker image #355

merged 1 commit into from
Oct 8, 2019

Conversation

veblush
Copy link
Contributor

@veblush veblush commented Sep 26, 2019

I roughly manage to create a manylinux2010-i686 docker image based on CentOS 6. CentOS 6 is pretty old and i686 doesn't get enough attention so there are a couple of issues to be resolved unlike x86_64.

  • There is no i686 devtoolset-8 in SCL so I replaced it with the devtoolsset-7 in cloud linux repo. Having the same version would be the best but 7.3 is still much better than built-in gcc 4.4.
  • CentOS 6 has a problem on curl with installed certificates so I have to add "-k" option to curl as a workaround. (I tried to update the existing system certificate but it didn't work)
  • auditwheel doesn't have a proper list of symbols for i686. PR is now ready.
  • CentOS 6 32bit doesn't seem to have a vsyscall=emualate issue unlike x86_64 so it can run smoothly without the monkey patch that x86_64 base image has.

Any suggestion to enhance this is welcome!

Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veblush, can you update the .travis.yml for the image to be built please ?

docker/build_scripts/build.sh Outdated Show resolved Hide resolved
@veblush
Copy link
Contributor Author

veblush commented Sep 26, 2019

@mayeut, I added i686 test to .travis running in a sequential fashion but I believe that there must be a more efficient way like using parallel execution (matrix or something?). If you know how to, please let me know.

.travis.yml Show resolved Hide resolved
Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Waiting for auditwheel release

@veblush
Copy link
Contributor Author

veblush commented Sep 28, 2019

Thank you for the review!

And then how can we initiate the auditwheel release process? Once it's released with the next version (let's say 2.2) and next action item would be to update auditwheel==2.1.0 to auditwheel==2.2.0 in py36-requirements.txt, right?

@mayeut
Copy link
Member

mayeut commented Sep 28, 2019

Once it's released with the next version (let's say 2.2) and next action item would be to update auditwheel==2.1.0 to auditwheel==2.2.0 in py36-requirements.txt, right?

Well yes but not in your PR directly, once auditwheel gets released, a PR will be automatically created for the master branch. Once this PR is merged, you'll need to rebase your branch on master (& if possible squash the commits in one)

Copy link
Member

@mayeut mayeut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@veblush, can you rebase & squash your changes please ?

@veblush
Copy link
Contributor Author

veblush commented Oct 8, 2019

Done. I appreciate your help on this! 😄

@mayeut mayeut merged commit 99c1938 into pypa:master Oct 8, 2019
@veblush
Copy link
Contributor Author

veblush commented Oct 8, 2019

Grad to see this merged. Is there something to do in order to have quay.io/pypa/manylinux2010_i686 or just matter of time?

@veblush veblush deleted the i686 branch October 8, 2019 19:54
@mayeut
Copy link
Member

mayeut commented Oct 8, 2019

Should be a matter of time, you can follow the progress here

@mayeut
Copy link
Member

mayeut commented Oct 8, 2019

argh, build failed because the repo does not exist on quay.io

@njsmith, @rmcgibbo, @takluyver, can you create the repo quay.io/pypa/manylinux2010_i686 please ?

@rmcgibbo
Copy link
Member

rmcgibbo commented Oct 8, 2019

done. i think

@mayeut
Copy link
Member

mayeut commented Oct 8, 2019

Thanks @rmcgibbo, I restarted the build, we'll see if it gets deployed this time.

@mayeut
Copy link
Member

mayeut commented Oct 8, 2019

@rmcgibbo, unfortunately the build is still failing.

@takluyver
Copy link
Member

I've had a go at making the permissions for that repo match the other manylinux2010 one - try now.

@takluyver
Copy link
Member

Or I guess I can press restart as well as anyone else. 😛 I'm going to bed now, so hopefully it will work this time.

@mayeut
Copy link
Member

mayeut commented Oct 9, 2019

Thanks @takluyver, image is now deployed.

@takluyver
Copy link
Member

Thanks everyone who figured out how to make the i686 image. :-)

@veblush
Copy link
Contributor Author

veblush commented Oct 9, 2019

Thank you for uploading!

@ax3l ax3l mentioned this pull request Apr 13, 2020
grzanka pushed a commit to grzanka/manylinux that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants