Skip to content

Commit

Permalink
Re-enable location warning
Browse files Browse the repository at this point in the history
  • Loading branch information
uranusjr committed Jul 10, 2021
1 parent f37fc4c commit 802fc20
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
2 changes: 2 additions & 0 deletions news/10151.removal.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Re-enable the "Value for ... does not match" location warnings to field a new
round of feedback for the ``distutils``-``sysconfig`` transition.
8 changes: 6 additions & 2 deletions src/pip/_internal/locations/__init__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import logging
import os
import pathlib
import sys
import sysconfig
Expand Down Expand Up @@ -45,13 +46,16 @@ def _default_base(*, user: bool) -> str:
def _warn_if_mismatch(old: pathlib.Path, new: pathlib.Path, *, key: str) -> bool:
if old == new:
return False
issue_url = "https:/pypa/pip/issues/9617"
issue_url = "https:/pypa/pip/issues/10151"
message = (
"Value for %s does not match. Please report this to <%s>"
"\ndistutils: %s"
"\nsysconfig: %s"
)
logger.debug(message, key, issue_url, old, new)
if os.environ.get("_PIP_LOCATIONS_NO_WARN_ON_MISMATCH"):
logger.debug(message, key, issue_url, old, new)
else:
logger.warning(message, key, issue_url, old, new)
return True


Expand Down

0 comments on commit 802fc20

Please sign in to comment.