Skip to content

Commit

Permalink
Deprecate custom progress bar styles
Browse files Browse the repository at this point in the history
Maintaining these is not particularly useful, since the progress bar
provided by rich is capable of degrading gracefully to ASCII and
alternative styles provided today aren't particularly usable either.
  • Loading branch information
pradyunsg committed Nov 12, 2021
1 parent 5d07b09 commit bf1c350
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/pip/_internal/cli/req_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,13 @@ def make_requirement_preparer(
gone_in="22.1",
)

if options.progress_bar not in {"on", "off"}:
deprecated(
reason="Custom progress bar styles are deprecated",
replacement="to use the default progress bar style.",
gone_in="22.1",
)

return RequirementPreparer(
build_dir=temp_build_dir_path,
src_dir=options.src_dir,
Expand Down

0 comments on commit bf1c350

Please sign in to comment.