Fish completion not working for files (.whl)

[Holt59]

Description

When installing from a local file, e.g. a wheel, auto-completion does not work in fish shell:

$ ls *.whl
package.whl
$ pip install ./pack  # no completion

Expected behavior

I expected ./pack to be auto-completed to ./package.whl

pip version

21.3.1

Python version

3.9.7

OS

Ubuntu 20.04

How to Reproduce

1. Create a package.whl file in the current folder (either a real one or a dumb one).
2. Start fish shell (current folder)
3. Start typing pip install pack

Output

No response

Code of Conduct

• I agree to follow the PSF Code of Conduct.

[notatallshaw]

Have you run the completion setup documented here: https://pip.pypa.io/en/stable/user_guide/#command-completion

[Holt59]

I just did but now I get:

complete: Unknown option “-m”                                                                                                           643ms  Tue 09 Nov 2021 03:59:51 PM CET

~/.config/fish/completions/pip.fish (line 11): 
complete -fa "(__fish_complete_pip)" -c /usr/bin/python3 -m pip
^
from sourcing file ~/.config/fish/completions/pip.fish
in command substitution

(Type 'help complete' for related documentation)

Doing the version with eval seems to work if I use pip3 instead of python3 -m pip but then I get completion for parameters but the problem with files is still there.

[rouge8]

It looks like this is expected behavior:

pip/tests/functional/test_completion.py

Lines 235 to 256 in 3fd3a97

	def test_completion_not_files_after_option(
	autocomplete: DoAutocomplete, data: TestData
	) -> None:
	"""
	Test not getting completion files after options which not applicable
	(e.g. ``pip install``)
	"""
	res, env = autocomplete(
	words=("pip install r"),
	cword="2",
	cwd=data.completion_paths,
	)
	assert not any(
	out in res.stdout
	for out in (
	"requirements.txt",
	"readme.txt",
	)
	), "autocomplete function completed <file> when it should not complete"
	assert not any(
	os.path.join(out, "") in res.stdout for out in ("replay", "resources")
	), "autocomplete function completed <dir> when it should not complete"

I think this is wrong though, it should offer to complete wheel and sdist files...

[uranusjr]

Feel free to propose a pull request for this.

[rouge8]

PR at #10682