Don't trust link hash in direct URL dependencies #11938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
force-pushed
the
fix-direct-url-hash-trusted-sbi
branch
from
cc36902
to
d0cf1ad
Compare
uranusjr
approved these changes
Apr 10, 2023
1 task
When a direct URL with hash is provided as a dependency, --require-hash incorrectly considered the link hash as trusted.
sbidoul
force-pushed
the
fix-direct-url-hash-trusted-sbi
branch
from
b92e496
to
453a5a7
Compare
|
Rebased, 🟢 and approved, so merging. Thanks for the review @uranusjr ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When package A depends on package B provided as a direct URL dependency including a hash embedded in the link, the
--require-hashesoption did not warn when user supplied hashes were missing for package B.Also add a some more test coverage for link hash validation.