Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install ordering issue with pip 6.0.8 and setuptools 12.3 #2473

Closed
ianw opened this issue Mar 4, 2015 · 3 comments
Closed

install ordering issue with pip 6.0.8 and setuptools 12.3 #2473

ianw opened this issue Mar 4, 2015 · 3 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@ianw
Copy link
Contributor

ianw commented Mar 4, 2015

We are seeing this in upstream openstack testing.

we use get-pip.py and "pip install -U setuptools" on our centos7 hosts.

One of the projects recently added "cryptography" as a requirement. This requires "six > 1.9" to install, which is correctly specified.

But when it comes time to install, the updated six package isn't installed before cryptography, e.g. replicating by hand

[root@devstack-ps centos]# pip list | grep setuptools
setuptools (12.3)
[root@devstack-ps centos]# pip install "six>=1.9" cryptography
Collecting six>=1.9
  Using cached six-1.9.0-py2.py3-none-any.whl
Collecting cryptography
  Using cached cryptography-0.7.2.tar.gz
Requirement already satisfied (use --upgrade to upgrade): cffi>=0.8 in /usr/lib64/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): pyasn1 in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): setuptools in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): enum34 in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): pycparser in /usr/lib/python2.7/site-packages (from cffi>=0.8->cryptography)
Installing collected packages: cryptography, six
  Running setup.py install for cryptography
    zip_safe flag not set; analyzing archive contents...
    six: module references __path__
    Installed /tmp/pip-build-jdrcAF/cryptography/.eggs/six-1.9.0-py2.7.egg
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-jdrcAF/cryptography/setup.py", line 339, in <module>
[blah blah blah]
        @six.add_metaclass(abc.ABCMeta)
    AttributeError: 'module' object has no attribute 'add_metaclass'

note the command line is pip install "six>=1.9" cryptography but pip says Installing collected packages: cryptography, six

so on a whim i swapped around the ordering on the command-line, and it installs correctly

[root@devstack-ps centos]# pip install cryptography "six>=1.9" 
Collecting cryptography
  Using cached cryptography-0.7.2.tar.gz
Collecting six>=1.9
  Using cached six-1.9.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): cffi>=0.8 in /usr/lib64/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): pyasn1 in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): setuptools in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): enum34 in /usr/lib/python2.7/site-packages (from cryptography)
Requirement already satisfied (use --upgrade to upgrade): pycparser in /usr/lib/python2.7/site-packages (from cffi>=0.8->cryptography)
Installing collected packages: six, cryptography
  Found existing installation: six 1.3.0
    DEPRECATION: Uninstalling a distutils installed project (six) has been deprecated and will be removed in a future version. This is due to the fact that uninstalling a distutils project will only partially uninstall the project.
    Uninstalling six-1.3.0:
      Successfully uninstalled six-1.3.0

  Running setup.py install for cryptography
    building '_Cryptography_cffi_4ee21876x41fb9936' extension
[blah blah]

so i think the ordering is getting switched around somewhere
@ianw
Copy link
Contributor Author

ianw commented Mar 4, 2015

I should note the requirements file providing the order of packages to install is

http://git.openstack.org/cgit/openstack/keystone/tree/requirements.txt

there is also a review upstream

https://review.openstack.org/161055

@piotr-dobrogost
Copy link

Duplicate of #2260

@taion taion mentioned this issue Mar 4, 2015
Closed
openstack-gerrit pushed a commit to openstack/keystone that referenced this issue Mar 5, 2015
@ianw
Move install of cryptography before six
86fc1c4 
With Ibca4b1765d06f239df113aa3ec367e60de61a225 a dependency on
cryptography was introduced.

This is causing issues for the centos7 devstack jobs.  cryptography
attempting to be installed before it's dependency "six".

I have filed an upstream issue with pip about this [1].  In the
mean-time, re-ordering the dependency should allow things to install
correctly.

This probably doesn't happen on Ubuntu because it ships with a version
of six that allows the cryptography package to at least install.

[1] pypa/pip#2473

Change-Id: I0308aca7ac4d59afbec342ec387be088f7d360ca
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Mar 5, 2015
@openstack-gerrit
Updated openstack/openstack
2df2f34 
Project: openstack/keystone  88559d31750c6b41e78bc0c360e3613ecb3af850

Move install of cryptography before six

With Ibca4b1765d06f239df113aa3ec367e60de61a225 a dependency on
cryptography was introduced.

This is causing issues for the centos7 devstack jobs.  cryptography
attempting to be installed before it's dependency "six".

I have filed an upstream issue with pip about this [1].  In the
mean-time, re-ordering the dependency should allow things to install
correctly.

This probably doesn't happen on Ubuntu because it ships with a version
of six that allows the cryptography package to at least install.

[1] pypa/pip#2473

Change-Id: I0308aca7ac4d59afbec342ec387be088f7d360ca
@dstufft
Copy link
Member

dstufft commented Apr 7, 2015

I think this is fixed now in 6.1.0.

@dstufft dstufft closed this as completed Apr 7, 2015
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piotr-dobrogost @ianw @dstufft