Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendoring script rewrites binascii import #5347

Closed
pfmoore opened this issue Apr 28, 2018 · 5 comments
Closed

Revendoring script rewrites binascii import #5347

pfmoore opened this issue Apr 28, 2018 · 5 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@pfmoore
Copy link
Member

pfmoore commented Apr 28, 2018

The revendoring script mistakenly rewrites an import of binascii from urllib3:

diff --git a/src/pip/_vendor/urllib3/util/ssl_.py b/src/pip/_vendor/urllib3/util/ssl_.py
index dafc75b5..87059434 100644
--- a/src/pip/_vendor/urllib3/util/ssl_.py
+++ b/src/pip/_vendor/urllib3/util/ssl_.py
@@ -3,7 +3,7 @@ import errno
 import warnings
 import hmac
 
-from binascii import hexlify, unhexlify
+from pip._vendor.binascii import hexlify, unhexlify
 from hashlib import md5, sha1, sha256
@hroncok
Copy link
Contributor

hroncok commented Apr 28, 2018

I know what's the deal here.

@hroncok
Copy link
Contributor

hroncok commented Apr 28, 2018

Let me test it and send a PR.

@pfmoore
Copy link
Member Author

pfmoore commented Apr 28, 2018

Fantastic - I was going to look into it, but haven't had the time yet. So much appreciated.

@hroncok
Copy link
Contributor

hroncok commented Apr 28, 2018

#5348

hroncok added a commit to hroncok/pip that referenced this issue Apr 28, 2018
It contains the executables: easy_install, distro, chardetect etc.

It should not be picked as vendored library.

Related to pypa#5347
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

2 participants