-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make link logging more consistent #7390
Labels
C: logging
Information Logging
state: awaiting PR
Feature discussed, PR is needed
type: refactor
Refactoring code
Comments
triage-new-issues
bot
added
the
S: needs triage
Issues/PRs that need to be triaged
label
Nov 22, 2019
xavfernandez
added
type: refactor
Refactoring code
C: logging
Information Logging
and removed
S: needs triage
Issues/PRs that need to be triaged
labels
Nov 22, 2019
I'd say we can drop the discussion needed and relabel this as awaiting PR. |
xavfernandez
added
state: awaiting PR
Feature discussed, PR is needed
and removed
state: needs discussion
This needs some more discussion
labels
Nov 22, 2019
Hello, I tried to pick up this issue, but this code snippet is not there anymore on the main branch, I think we can close this issue. |
There is still custom logic in e.g. url = link.url # Or e.g. url_without_fragment
redact_auth_from_url(url) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: logging
Information Logging
state: awaiting PR
Feature discussed, PR is needed
type: refactor
Refactoring code
What's the problem this feature will solve?
Links are sometimes logged via their
__str__
method (cfpip/src/pip/_internal/operations/prepare.py
Line 480 in 81f0572
pip/src/pip/_internal/operations/prepare.py
Lines 135 to 140 in 81f0572
And on top of that we have a special case for PyPI downloads.
Like Chris pointed out in #7384 (comment) this special case (reintroduced via #7225) doesn't help with debugging.
Describe the solution you'd like
Always use the same logic (a
Link
property (or__str__
) when logging a link, ideally with identical logic when dealing wih filepath or VCS urls.This could involve always using
link.show_url
for info logs and provide the full (redacted) url in--verbose
mode.Alternative Solutions
Statu quo.
The text was updated successfully, but these errors were encountered: