Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify logic for --download/--noinstall combination #907

Closed
qwcode opened this issue Apr 20, 2013 · 1 comment
Closed

simplify logic for --download/--noinstall combination #907

qwcode opened this issue Apr 20, 2013 · 1 comment
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code

Comments

@qwcode
Copy link
Contributor

qwcode commented Apr 20, 2013

there'seems to be logic and tests around --download/--noinstall being used together,
but currently it seems --download is the dominant option?
it seems we should just raise a command error that these options do nothing together.
(I intentionally left tests out of #865 with the intention of handling this in v1.4)

In v1.5, my intention is for both of these options to be renamed (see #906 )
@qwcode qwcode mentioned this issue Apr 20, 2013
Merged
@dstufft
Copy link
Member

dstufft commented Apr 7, 2015

I'm going to close this since --no-install is gone in 7.0.

@dstufft dstufft closed this as completed Apr 7, 2015
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstufft @qwcode