Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip wheel of editable requirements creates a .zip file in the wheel directory #9122

Closed
sbidoul opened this issue Nov 11, 2020 · 4 comments · Fixed by #9123
Closed

pip wheel of editable requirements creates a .zip file in the wheel directory #9122

sbidoul opened this issue Nov 11, 2020 · 4 comments · Fixed by #9123
Labels
C: editable Editable installations C: wheel The wheel format and 'pip wheel' command type: bug A confirmed bug or unintended behavior
Milestone

Comments

@sbidoul
Copy link
Member

sbidoul commented Nov 11, 2020

Environment

  • pip version: master branch, today
  • Python version: 3.8 (probably irrelevant)
  • OS: linux (probably irrelevant)

Description

Consider the following requirements.txt:

-e git+https:/PyPA/packaging@master#egg=packaging

When we run pip wheel -r requirements.txt --wheel-dir=wheelhouse, we now obtain packaging-20.5.dev0.zip in the wheelhouse directory, in addition to the expected whl files.

Expected behavior

Only wheels should be generated to the wheel-dir directory.

Analysis

This issue probably originates in #8843 around here although I'm not entirely sure yet.

@sbidoul sbidoul added C: editable Editable installations C: wheel The wheel format and 'pip wheel' command type: bug A confirmed bug or unintended behavior labels Nov 11, 2020
@sbidoul sbidoul added this to the 20.3 milestone Nov 11, 2020
@sbidoul
Copy link
Member Author

sbidoul commented Nov 11, 2020

Tentatively adding to 20.3 milestone as it looks like a regression.

@uranusjr
Copy link
Member

uranusjr commented Nov 11, 2020

Probably off-topic, but it feels weird to me that wheel accepts an editable requirement; I would expect it to error, or convert the requirement to non-editable with a warning.

@sbidoul
Copy link
Member Author

sbidoul commented Nov 11, 2020

@uranusjr see #3291 for why it exists (in a nutshell, creating installation bundles from requirement files).

@sbidoul
Copy link
Member Author

sbidoul commented Nov 12, 2020

I propose a fix in #9123. @McSinyx @pradyunsg since you worked on #8843 (and @pradyunsg actually had suspicions about that particular change), you input will be valuable here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: editable Editable installations C: wheel The wheel format and 'pip wheel' command type: bug A confirmed bug or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants