Smarter (and looser) link equivalency logic #10079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10002 (eventually).
Todo:
links_equivalent
.Add a--use-deprecated
flag to enable the current (stricter) behaviour in case this does not work for some cases.Decided to not do this since I don’t see how users would find this flag useful.
Add a deprecation warning whenegg=
is used. (How can we only show this once?)Not doing this for now, see Resolution conflict due to the PEP 508 requirement with superfluous #egg fragment specified in a package’s metadata #10002 (comment)
Dig out previous issues on this and close them (IIRC there are a couple).refactor pip's use of "#egg=" #1289 is the other issue about this, but that one is wider in scope and cannot be closed by this alone.