Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PEP 660 metadata preparation fallback #10577

Merged
merged 7 commits into from
Oct 21, 2021
Merged

Fix PEP 660 metadata preparation fallback #10577

merged 7 commits into from
Oct 21, 2021

Commits on Oct 18, 2021

  1. Add TODO

    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    d362431 View commit details
    Browse the repository at this point in the history

  2. Reject projects that have neither a pyproject.toml nor a setup.py

    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    ddfeaae View commit details
    Browse the repository at this point in the history

  3. Add failing tests for issue 10573

    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    619b257 View commit details
    Browse the repository at this point in the history

  4. Upgrade pep517 to 0.12.0

    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    b0eb95b View commit details
    Browse the repository at this point in the history

  5. Prepare legacy editable metadata in isolated env 

    When there is a pyproject.toml, metadata preparation must be
done in the isolated build environment for legacy editable installs too
(fixes a regression).

Also detect earlier if an editable install must go through the
legacy install path, to be sure to run it in an environment
with the correct build requirements.
    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    ae51289 View commit details
    Browse the repository at this point in the history

  6. Split _setup_isolation for readability

    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    b07a956 View commit details
    Browse the repository at this point in the history

  7. Simplify "Preparing metadata" logging 

    Do not mention wheel, as this code path is also used
in legacy editable mode with isolation, where
no wheel is involved.

This also aligns with the new log entry for setup.py egg-info
which says "Preparing metadata (setup.py)".
    @sbidoul
    sbidoul committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    106042f View commit details
    Browse the repository at this point in the history