Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] disentangle --no-binary #11373

Closed
wants to merge 5 commits into from
Closed

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Aug 12, 2022

This is a draft PR to illustrate the whole path towards disentangling --no-binary. Please do not do detailed code review here, it will be split in individual PRs for review. Questions and suggestions on the overall approach are most welcome here.

This is encapsulates my takeaways from #9778 and #9422.

  • deprecate --install-option (Deprecate --install-options #11359)

  • clarify the warning message when --install-option/--global-option/--build-option is used, saying that it implies --no-binary=:all: which is accurate, instead of disabling all use of wheel which was not entirely true in all cases. (also in Deprecate --install-options #11359)

  • add a dreprecation warning when --no-binary implies setup.py install

  • add a no-binary-builds-wheels feature flag which does the following when --no-binary is used:

    • instead of forcing setup.py install let it build and install a wheel (thereby silencing the deprecation warning)
    • enable the use of the cache of locally built wheels in pip install and pip wheel (the user can still control it with --no-cache)
  • pass --build-option and --global-option in the build step, like pip wheel does - if only for symmetry and to soften the transition; we nevertheless recommend users to use --config-settings and we'll likely deprecate these in the future, for pip install and pip wheel at the same time.

In itself, this commit does not change pip's behaviour,
because the presence of --build-option and --global-option imply
--no-binary :all: which in turn disable wheel building.
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've skimmed through this, and it seems reasonable overall.

@sbidoul
Copy link
Member Author

sbidoul commented Sep 17, 2022

So, coming back to this, I realize that:

@sbidoul sbidoul closed this Sep 17, 2022
@sbidoul sbidoul deleted the no-binary-staging-sbi branch September 17, 2022 12:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants