Remove deprecated --install-option
#11858
Conversation
sbidoul
force-pushed
the
rm-install-options-sbi
branch
from
61664b1
to
b93dd2d
Compare
sbidoul
changed the title
--install-option
sbidoul
changed the title
--install-option--install-option
|
🟢 @pypa/pip-committers is anyone not on board with removing support for |
sbidoul
added
project: setuptools
sbidoul
changed the title
--install-option--install-option
|
|
||
| The above translates roughly into running FooProject's `setup.py` script as: | ||
|
|
||
| python setup.py --no-user-cfg install --prefix='/usr/local' --no-compile | ||
| python setup.py --no-user-cfg install |
There was a problem hiding this comment.
Perhaps this install should be changed to bdist_wheel? I'm assuming that pip won't be using install anymore if --install-option is not used.
There was a problem hiding this comment.
@SpecLad yes, that is correct. I'll take care of this. Thanks!
There was a problem hiding this comment.
Hm, actually that will be for a subsequent PR that removes the setup.py install code path. This one just removes --install-option.
There was a problem hiding this comment.
I know that the setup.py install code path still exists, but I think in this example it's reasonable to assume that it won't be used in the absence of --install-option.
| @@ -161,7 +160,7 @@ This disables the use of wheels (cached or otherwise). This could mean that buil | |||
| This mechanism is only preserved for backwards compatibility and should be considered deprecated. A future release of pip may drop these options. | |||
There was a problem hiding this comment.
After this PR, there's only one option left (--global-option). Although it might be worth it to document --build-option in this section.
Also, GitHub won't let me comment on the correct line, but there's a warning about disabling the use of wheels above, which should no longer be relevant.
github-actions
bot
added
the
needs rebase or merge
sbidoul
force-pushed
the
rm-install-options-sbi
branch
from
b93dd2d
to
a04748d
Compare
|
I'm going to go ahead with this one and continue with the other removals scheduled for 23.1. @SpecLad thanks for your comments on the doc. I'll check again when everything is merged to verify it is still consistent. |
|
The MacOS test failure is unrelated, and the Windows failture is a transient. So merging. |
First step towards removing support for
setup.py install, as announced in the deprecation notices.closes #11358