Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for installed eggs distributions #12308

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 1, 2023

I could not find the deprecation issue for this, but this was scheduled for removal in 23.3.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 1, 2023

This is also not super urgent and could be deferred.

Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One news fragment change, but rest seems fine to me!

news/12308.removal.rst Outdated Show resolved Hide resolved
@sbidoul
Copy link
Member Author

sbidoul commented Oct 1, 2023

Thinking further about this, I'd propose to defer the removal for one year at least because

  • we are not nearly close to removing pkg_resources
  • the removal of the setup.py install code path was not so long ago and users may unknowingly have installed eggs if they did not have wheel installed, which was also the default for python -m venv
  • if we remove discovery, uninstallation must be done manually and this may generate a lot of support issues

@uranusjr
Copy link
Member

uranusjr commented Oct 2, 2023

It’s also only until recently related issues started popping up (#12297 and IIRC there’s another one I closed). Either distributions take a lot of time to upgrade to Python 3.11, or people take a lot of time to upgrade to it. In either case, more time is likely a good idea since removing the warning would simply cause dangling files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants