list: disable pip version self check unless given --outdated/--uptodate #12568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Mar 12, 2024
| @@ -161,6 +161,10 @@ class IndexGroupCommand(Command, SessionCommandMixin): | |||
| This also corresponds to the commands that permit the pip version check. | |||
| """ | |||
|
|
|||
| def __init__(self, *args: Any, **kwargs: Any) -> None: | |||
| super().__init__(*args, **kwargs) | |||
| self.allow_pip_version_check = True | |||
There was a problem hiding this comment.
This makes this class a little bit at odds with its docstring.
|
If we do this for |
They don't perform the pip version self-check ever already. pip list is unique because it can optionally access the network (when passed |
|
I'm going to write a new patch that deals with this issue and makes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11677.
Not sure how to write a test for this, suggestions are welcome...