Calculate candidate string versions only once in get_applicable_candidates
#12664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor performance, I measure it at 1% fairly consistently across different resolutions I've tried.
I was looking at the "After call graph" in #12663 and noticed that
get_applicable_candidates
was taking 16% of run time, and even though it was only called 921 times it is calling other methods hundreds of thousands of times.The only obvious thing I spotted though is it effectively calculating
[c.version for c in candidates]
twice, and can be seen on this part of the call graph:Highlighted call graph
I suspect though that this function has further significant optimization, so I will leave it as draft for now and think on it and take any suggestions, before marking it ready for review.