Add vendored and test import groups to import sorting #12974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatallshaw
changed the title
ichard26
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
This looks a bit weird, but most of our test files aren't this tiny :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always found import groups a little weird in the test directory, because vendored libraries are mixed with third party libraries, and test imports are mixed with pip internal imports.
This change explicitly defines all the import groups, adding two new groups, "vendored" and "tests", because these are otherwise in the same order as the implicit import groups but with two new ones it just adds additional spaces to those groups.