'pip wheel' should download wheels, when it finds them #1524
Conversation
|
|
||
| # a download dir is specified and not already downloaded | ||
| if download_dir and not already_downloaded: | ||
| content_type = mimetypes.guess_type(link_path)[0] |
There was a problem hiding this comment.
if link_path has a hash fragment, needs a hash confirmation here. will add that.
I'm tempted to consolidate unpack_http_url and unpack_file_url, but concerned it will get too complex.
There was a problem hiding this comment.
When I was trying to grok pip's code, it seemed to me that 'download a resource' and 'extract it' were really poorly separated tasks, where it would be useful to have them as clearly separate steps.
There was a problem hiding this comment.
Keep in mind that in order to do recursive downloads (and pip install --download does that), the packages have to be extracted/unpacked so the metadata can be inspected for dependencies.
I think a good time to try to do more separation, might be with pip download in #906
'pip wheel' should download wheels, when it finds them
lock
bot
added
the
auto-locked
fix for #1310 (and indirectly for #1111)
still need to handle #855 and in general work on clearing up pip's overwrite/"exists_action" behavior.