Run setup.py develop inside of PEP 518 build environment

[ghost]

Don't look at this until gh-4799 is merged.

[ghost]

I'm closing this because it seems to have caused unnecessary confusion about gh-4799.

[pypa-bot]

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

[ghost]

cc @pradyunsg

[pfmoore]

Looks OK to me. Can you fix the lint issue (unused result var in the test) and add a news file? Hopefully PyPy3 will complete when the fixes are submitted.

[ghost]

@pfmoore pypy has timed out (again).

[pradyunsg]

Restarted.

…

On Fri, 2 Mar 2018, 01:18 xoviat, ***@***.***> wrote: @pfmoore <https:/pfmoore> pypy has timed out (again). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4999 (comment)>, or mute the thread <https:/notifications/unsubscribe-auth/ADH7SZdsAmR0TnrHmSthwSjkk6VuBiyxks5taFCUgaJpZM4Rv5UP> .

[pfmoore]

I'm getting very sick of the PyPy3 checks :-( @pradyunsg @dstufft what do you think about making that check optional (like Python nightly)? Is PyPy 3 a critical platform for us?

[pfmoore]

@pradyunsg Could you give this a quick check before I merge? I'd appreciate your confirmation as it's PEP 518 related.

[ghost]

Wow, this is lightning speed!

[pfmoore]

Small changes, easy to review 😉

[pradyunsg]

PyPy3 checks

I'm happy to make them optional for a short term fix. I want them to be run regularly and that we don't ignore their failures though.

Small changes, easy to review 😉

+1

[pradyunsg]

Ideally, we should fix them but I'm pretty sure no one has the bandwidth right now, so, ignoring failures is fine. I'll make a PR for this.