Fix PackageFinder to respect allow_all_prereleases

[sauhard]

Fix 'PackageFinder.find_all_candidates' to respect 'allow_all_prereleases'
Closes #5175

[benoit-pierre]

You broke this use case:

$ cp tests/data/packages/simplewheel-1.0-py2.py3-none-any.whl index/foo-1.0-py2.py3-none-any.whl
$ cp tests/data/packages/simplewheel-1.0-py2.py3-none-any.whl index/foo-1.0b1-py2.py3-none-any.whl
$ python src/pip download --no-deps -f index 'foo>=2.0b1'
Looking in links: index
Collecting foo>=1.0
  Saved ./foo-1.0-py2.py3-none-any.whl
Successfully downloaded foo
# Instead of:
$ git checkout master
$ python src/pip download --no-deps -f index 'foo>=2.0b1'                                        
Looking in links: index
Collecting foo>=2.0b1
  Saved ./foo-2.0b1-py2.py3-none-any.whl
Successfully downloaded fo

As evidenced by the fact that you had to patch test_finder_installs_pre_releases_with_version_spec to make the test pass.

[micheleAlberto]

I misunderstood the meaning of that test; will follow up

[benoit-pierre]

OK, I had made a mess of the test... The point is: when using a requirement with a version specifiers using a pre-release, then pre-releases should be allowed (same as if --pre was used).

[micheleAlberto]

I opened #5928 and suggest to close this one

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.