Move DistAbstraction and subclasses into a 'distributions' subpackage #6109
Conversation
pradyunsg
force-pushed
the
refactor/distributions
branch
from
7b24e7e
to
7462db8
Compare
pradyunsg
added
the
skip news
| @@ -0,0 +1,25 @@ | |||
| from pip._internal.distributions.source import SourceDistribution as _SrcDist | |||
| from pip._internal.distributions.wheel import WheelDistribution as _WhlDist | |||
There was a problem hiding this comment.
_names were too long for linter to be happy and I don't want people to do from from pip._internal.distributions import XYZ -- mentioning Source/Wheel Distribution is okay for now.
Eventually, this file should be empty anyway. :)
| @@ -0,0 +1,26 @@ | |||
| class AbstractDistribution(object): | |||
| """A base class that abstracts information about | |||
There was a problem hiding this comment.
I think it's better to put any changes to moved code (e.g. class renames, method renames, etc) in commits separate from the move operation, because otherwise you can't really tell what changes are being made to the moved classes. Like above, there is an incomplete docstring, but it wasn't like that in the original.
There was a problem hiding this comment.
Duly noted. I'll take care of this in the future. :)
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
|
Yea, not now. Later. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Built on top of #6060
Step 4 of #5051, creating a location for placing separated logic for source/wheel/installed distributions in a better way.