Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact index password from logs #6125

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Redact index password from logs #6125

merged 1 commit into from
Jan 10, 2019

Conversation

xavfernandez
Copy link
Member

Closes #6124

@xavfernandez xavfernandez added this to the 19.0 milestone Jan 9, 2019
cjerdonek
cjerdonek reviewed Jan 10, 2019
View reviewed changes
news/6124.bugfix Outdated
@@ -0,0 +1 @@
Redact index urls when using --no-index & --verbose option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would spell this a bit out more fully, for example:

Redact the password from index urls in certain debug messages (--no-index and --verbose options).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with either wording.

pradyunsg
pradyunsg approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xavfernandez xavfernandez merged commit a099136 into pypa:master Jan 10, 2019
@xavfernandez xavfernandez deleted the redact_indexes branch January 10, 2019 09:47
@xavfernandez
Copy link
Member Author

Thanks for the quick reviews :)

@lock
Copy link

lock bot commented May 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@cjerdonek cjerdonek cjerdonek approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
19.0
Development

Successfully merging this pull request may close these issues.

Indexes with password are not redacted when using --no-index --verbose
3 participants
@xavfernandez @cjerdonek @pradyunsg