Add Subversion.get_vcs_version method

[johnthagen]

Relates to #6386

cc @cjerdonek

[cjerdonek]

Thanks for the PR!

In addition to my review comments, can you also follow the pattern in the following PR and add a test_ensure_svn_available() test that runs only on Travis? #6139

That way we can be sure that your test that requires svn to be installed will be running in at least one test environment in CI.

[johnthagen]

@cjerdonek Just an FYI, I agree with all of your formatting suggestions. I tried to keep this function consistent with the one for Git (where most of these issues are present currently):

pip/src/pip/_internal/vcs/git.py

Lines 68 to 79 in 54b6a91

	def get_git_version(self):
	VERSION_PFX = 'git version '
	version = self.run_command(['version'], show_stdout=False)
	if version.startswith(VERSION_PFX):
	version = version[len(VERSION_PFX):].split()[0]
	else:
	version = ''
	# get first 3 positions of the git version because
	# on windows it is x.y.z.windows.t, and this parses as
	# LegacyVersion which always smaller than a Version.
	version = '.'.join(version.split('.')[:3])
	return parse_version(version)

[cjerdonek]

I tried to keep this function consistent with the one for Git (where most of these issues are present currently)

Yeah, I noticed that. The Git one can be fixed up later to be more in line with this one.

[johnthagen]

@cjerdonek I think I've addressed all of your feedback. Thanks for the detailed responses.

[cjerdonek]

Thanks -- looking good! A few more comments.

[cjerdonek]

Thanks! A few more (final?) comments.

[cjerdonek]

Just a few more tiny things..

[cjerdonek]

Thank you, @johnthagen! 💯

[johnthagen]

Thanks for the mentoring @cjerdonek!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.