Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unquote path before testing for '@' #6441

Closed
wants to merge 3 commits into from
Closed

Conversation

cedk
Copy link

@cedk cedk commented Apr 24, 2019

The url can be quoted so the '@' will be %20 and it will not be split as
revision number.

Fixes: #6437

@cedk
Copy link
Author

cedk commented Apr 24, 2019

For the record, our CI is failing since the last pip release with this error: https://drone.tryton.org/tryton/modules.account_invoice/176/8
I do not know why now the URL is quoted.

The url can be quoted so the '@' will be %20 and it will not be split as
revision number.
@cjerdonek
Copy link
Member

FYI, this issue is being tracked here: #6437

@cjerdonek
Copy link
Member

@cedk Thanks for your work on this, but I think I prefer the approach being done in PR #6440. One reason is that the approach being done here won't work if a quoted @ is part of the revision string name.

@cjerdonek
Copy link
Member

This issue was addressed by PR #6440 using a slightly different approach, so closing. Thanks for your help though, @cedk!

@cjerdonek cjerdonek closed this Apr 25, 2019
@lock
Copy link

lock bot commented May 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install from internal pypi server containing git links fails with pypi 19.1
2 participants