Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align interface of tests.lib.path.Path.mkdir with pathlib.Path.mkdir #6888

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Align interface of tests.lib.path.Path.mkdir with pathlib.Path.mkdir #6888

merged 1 commit into from
Oct 7, 2019

Conversation

chrahunt
Copy link
Member

Progresses #6050.

@chrahunt chrahunt added skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes labels Aug 17, 2019
@chrahunt chrahunt mentioned this pull request Aug 17, 2019
Closed
@pradyunsg
Copy link
Member

CI is failing -- it seems like some of these directories already exist when the test runs. Perhaps change those up to assert path.exists() equivalent?

@pradyunsg
Copy link
Member

Ping.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Sep 15, 2019
@pradyunsg
Copy link
Member

@pfmoore Any suggestions on how to deal with the Windows failures on AppVeyor?

@pfmoore
Copy link
Member

pfmoore commented Sep 15, 2019

Sorry, I won't be able to look at this any time soon. RL issues are taking up most of my time right now.

@pradyunsg pradyunsg added the help wanted For requesting inputs from other members of the community label Sep 15, 2019
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Sep 15, 2019
@chrahunt chrahunt removed the help wanted For requesting inputs from other members of the community label Oct 7, 2019
@pradyunsg pradyunsg changed the title Align interface of tests.lib.path.Path.mkdir with pathlib.Path.mkdir. Align interface of tests.lib.path.Path.mkdir with pathlib.Path.… Oct 7, 2019
@pradyunsg pradyunsg merged commit 6d86a04 into pypa:master Oct 7, 2019
@pradyunsg pradyunsg changed the title Align interface of tests.lib.path.Path.mkdir with pathlib.Path.… Align interface of tests.lib.path.Path.mkdir with pathlib.Path.mkdir Oct 7, 2019
@chrahunt chrahunt deleted the maint/fix-path-mkdir branch October 7, 2019 06:51
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chrahunt @pradyunsg @BrownTruck @pfmoore @pypa-bot