Introduce an index sub-package
#7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: refactor
pradyunsg
force-pushed
the
index-sub-package
branch
2 times, most recently
from
41ceeea
to
7d9deeb
Compare
duckinator
reviewed
Oct 8, 2019
chrahunt
reviewed
Oct 9, 2019
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
Why: To better group code that handles index interactions.
Renames pip._internal.{collector -> index.collector} and
pip._internal.{index -> index.package_finder}
Co-Authored-By: Ellen Marie Dash <[email protected]>
pradyunsg
force-pushed
the
index-sub-package
branch
from
92a3e2d
to
3846da7
Compare
I'm making this change since it's unlikely that folks would've linked to this specific section, and if they did, this isn't exactly user facing documentation, so I wouldn't hold this to the same standard.
chrahunt
approved these changes
Oct 20, 2019
atugushev
added a commit
to atugushev/pip-tools
that referenced
this pull request
Oct 20, 2019
PackageFinder moved to pip._internal.index.package_finder FormatControl moved to pip._internal.models.format_control See: pypa/pip#7144
2 tasks
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: IMO, it makes sense to group all of our index interaction code into a single unit, so that someone who's not familiar with this part of the codebase (i.e. me) isn't baffled by the fact that
collector.pyis where we have network interactions. :)