Centralize setuptools args construction #7175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
type: refactor
chrahunt
force-pushed
the
refactor/centralize-setuptools-args
branch
from
01199b0
to
8af0dc2
Compare
To prepare for factoring these out into a separate module.
xavfernandez
approved these changes
Oct 18, 2019
pradyunsg
reviewed
Oct 18, 2019
|
Thanks @xavfernandez and @pradyunsg! And no worries, if there are any issues with this we will probably feel it in upcoming refactoring and can always address in a followup. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By making the inputs to setuptools explicit, it will be easier to construct a higher-level object responsible for representing the legacy build interface.