Remove interpreter-specific major version tag #7355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/ this tag doesn't make much sense + it impedes our usage of packaging.tags. In terms of backwards-compatibility, we attest to try to match compatible wheels as best as possible, and this tag doesn't represent that.
chrahunt
added
type: refactor
pradyunsg
removed
the
skip news
|
Sounds like a good idea to me. This is a minor removal that's not documented, so I don't think there's any good case to do a deprecation cycle here, yes, but this is still a change in user-facing behavior and I think calling it out in our NEWS would be a good way to minimally communicate this change. IMO we should mention this change in a |
|
Added removal news. |
xavfernandez
approved these changes
Nov 16, 2019
|
Thanks @pradyunsg for the comment and @xavfernandez for the review! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/
this tag doesn't make much sense + it impedes our usage of
packaging.tags.
In terms of backwards-compatibility, we attest to try to match
compatible wheels as best as possible, and this tag doesn't represent
that.
See also pypa/packaging#187 (comment).
Progresses #6908.