Redact passwords from index-url during download #7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
suggested changes
Nov 17, 2019
Made changes in _download_url so that it relies on redact_auth_from_url from misc to redact passwords. Closes #6783
chrahunt
approved these changes
Nov 17, 2019
|
The read the docs build has been failing periodically, we're working with them on it so I'll merge this. |
|
Thanks so much for your contribution! If you're interested in doing more feel free to check out the other open issues. We've pre-vetted the ones marked "good first issue" and (usually) the ones marked "awaiting PR" as being available to work on. If the next steps for any of those seems unclear please don't hesitate to leave a comment saying so. |
|
Sure thing. |
|
It could be more active, but it's as good a place as any for real-time communication. For reliability I think the issue tracker is best. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes in _download_url so that it relies on redact_auth_from_url from misc to redact passwords.
Closes #6783
Supersedes #6834.