Simplify _should_cache #8145
Merged
Simplify _should_cache #8145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition "never cache if pip install would not have built" can be simplified to "do not cache editable requirements". This is easier to read, and avoid a double warning if the 'wheel' package is not installed.
sbidoul
added
type: refactor
pradyunsg
approved these changes
Apr 27, 2020
13 tasks
|
This one should be good to go now that 20.1.1 is out. |
|
Thanks @pradyunsg ! |
|
Thank you for figuring this out and making the PR. :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition "never cache if pip install would not have built"
can be simplified to "do not cache editable requirements".
This is easier to read, and avoids a double warning if the 'wheel'
package is not installed.
Note the test for
req.source_diris copied as is from_should_buildso the code is equivalent.I suspect it is not necessary, but this can be left for a future refactoring.
Towards #8102