Test RECORD population for data files #8547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
added
C: tests
chrahunt
force-pushed
the
test-record-population
branch
2 times, most recently
from
3f96af3
to
3962897
Compare
|
Would this be a good chance to also add some (xfail) tests for #8521? |
|
I'd rather address that separately (alongside the several other issues I'm sure exist :)). I also had #8534 which improves the situation a bit around header file handling. |
chrahunt
force-pushed
the
test-record-population
branch
from
3962897
to
ffddab6
Compare
|
Any other comments on this, given we've identified the root cause for #8521? |
pradyunsg
approved these changes
Jul 8, 2020
|
Thank you both for taking a look! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't have coverage for this behavior (since I was able to locally break it without noticing), so this adds some. Specifically we now validate:
make_wheeltest helper correctly populatesMETADATA.datadirectories within wheels have their paths correctly translated inRECORDwhen installed