Refactor test for empty directory in wheel #8548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our previous test required that the implementation use a temporary directory and unpack the wheel in-place. Now we just provide a conventional empty directory in the wheel file itself.
chrahunt
added
C: tests
chrahunt
changed the title
uranusjr
approved these changes
Jul 6, 2020
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a comment by @xavfernandez in #7483 (comment). This also removes one of the places we were depending on a fully unpacked wheel, bringing us closer to direct-from-wheel installation.
Progresses #6030.