Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache found candidates #8912

Merged
merged 4 commits into from
Sep 27, 2020
Merged

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr added C: finder PackageFinder and index related code C: new resolver labels Sep 24, 2020
@pfmoore
Copy link
Member

pfmoore commented Sep 24, 2020

LGTM, I like this :-)

@pradyunsg
Copy link
Member

Add the NEWS fragment, and we're good to go? :P

@uranusjr
Copy link
Member Author

Fragment added. I categorise this as a feature since it is (arguably) an improvement of something that already works, that just “happens” to also resolve a performance bug.

@uranusjr
Copy link
Member Author

Hmm. Does the news bot not accept .rst suffixes yet?

@pfmoore
Copy link
Member

pfmoore commented Sep 26, 2020

It should just be named news/8905.feature, I think. It will still be parsed as ReStructured text

@uranusjr uranusjr marked this pull request as ready for review September 26, 2020 11:55
@pradyunsg
Copy link
Member

Hmm. Does the news bot not accept .rst suffixes yet?

Uhhhhhhhh... Looks like no.

@pradyunsg pradyunsg merged commit 703d6ac into pypa:master Sep 27, 2020
@uranusjr uranusjr deleted the cache-found-candidates branch September 27, 2020 14:22
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 12, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 12, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 16, 2020
pradyunsg added a commit to pradyunsg/pip that referenced this pull request Oct 16, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: finder PackageFinder and index related code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants