Don't crash on 'check' when METADATA is missing #8926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8676.
Ideally I’d want to catch only corruption failure for that specific package and carry on with others, but that does not seem feasible without patching
pkg_resources
.Since we already swallow corrupted metadata exceptions, it is probably not a terrible idea to swallow
OSError
anyway. Hopefully theimportlib.metadata
migration would provide a more useful way to handle these errors.