Add support for $EDITOR with arguments #9010
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pip config edit" doesn't work if "$EDITOR" also provides an argument for the editor. This commit fixes that. The common example is "EDITOR=code -w", which is useful to have vscode as the editor for "git commit". The "-w" ensures that the "code" process doesn't exit until the tab for the edited file is closed.
|
Please see #7392 if you haven't already. |
Oh, wow, no. This seemed very trivial, so I didn't search for existing issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"pip config edit" doesn't work if "$EDITOR" also provides an argument for the editor. This commit fixes that.
The common example is "EDITOR=code -w", which is useful to have vscode as the editor for "git commit".
The "-w" ensures that the "code" process doesn't exit until the tab for the edited file is closed.
I need a PR number to create the NEWS fragment (since there is no issue) so will add that immediately after opening the PR