Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always close stderr after subprocess completion in call_subprocess() #9156

Merged
merged 1 commit into from
Nov 21, 2020
Merged

Always close stderr after subprocess completion in call_subprocess() #9156

merged 1 commit into from
Nov 21, 2020

Commits on Nov 21, 2020

  1. Always close stderr after subprocess completion in call_subprocess() 

    When running Python with warnings enabled, fixes warnings of the form:

    .../site-packages/pip/_internal/vcs/versioncontrol.py:773: ResourceWarning: unclosed file <_io.BufferedReader name=12>
      return call_subprocess(cmd, cwd,
    @jdufresne
    jdufresne committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    8662248 View commit details
    Browse the repository at this point in the history