Cache AlreadyInstalledCandidate #9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
new-resolver-cache-installed-candidates
branch
from
af94239
to
1fc95f4
Compare
Since the "Requirement already satisfied" message is printed during candidate preparation, instantiating the candidate multiple times result in excessive logging during intensive backtracking. By caching the already-installed candidates, each package is only prepared, and thus only logged once.
uranusjr
force-pushed
the
new-resolver-cache-installed-candidates
branch
from
1fc95f4
to
120105d
Compare
pfmoore
approved these changes
Dec 11, 2020
pradyunsg
approved these changes
Dec 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the "Requirement already satisfied" message is printed during candidate preparation, instantiating the candidate multiple times result in excessive logging during intensive backtracking. By caching the already-installed candidates, each package is only prepared, and thus only logged once.
Close #9117.
This does not make the resolver any faster (multiple issues can be used to track this optimisation, e.g. #9215). The patch only fixes the repetitive logging.