Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of format_help #5872

Merged
merged 3 commits into from
Aug 26, 2023
Merged

Fix usage of format_help #5872

merged 3 commits into from
Aug 26, 2023

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Aug 26, 2023

Fix how format_help is used.
Because it uses click.echo color strings, one should not use console.print.

Fix #5869
Fix #5850

@oz123 oz123 requested a review from matteius August 26, 2023 08:27
@@ -71,8 +71,7 @@ def unnest(elem: Iterable) -> Any:
for el in target:
if isinstance(el, Iterable) and not isinstance(el, str):
el, el_copy = tee(el, 2)
for sub in unnest(el_copy):
yield sub
yield from unnest(el_copy)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually have a bigger refactor/simplification of this method in my open PR that will conflict with this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well. Then let's merge this with out caring for ruff. We'll fix ruff in the next PRs

@matteius matteius merged commit 60c8c97 into main Aug 26, 2023
19 checks passed
@matteius matteius deleted the fix-5869-5850 branch August 26, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants