Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A temporary workaround for pip 18.1 issues #2926

Closed
wants to merge 2 commits into from

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Oct 5, 2018

A quick workaround to fix #2924, not tested. If acked, please release a new version of Pipenv not to keep systems failing on every new Pipenv installation.

@Froskekongen
Copy link

Since this has happened before, wouldn't a long-term solution be to always pin pip to versions that work, and for a new release check if newer versions of pip is acceptable?

What would be better options? I am asking because I really need to have control of a (very) large python environment.

@uranusjr
Copy link
Member

uranusjr commented Oct 5, 2018

@Froskekongen The long-term solution is to refactor pip and extract common parts into their own library, so we can have a stable Python API independent to pip releases. This is already being worked on, but pip’s code base is not very easy to work with.

For short-term (or middle-term), the best way to help would be to constantly help test Pipenv against the master branch of pip, and alert us if anything is failing.

@greysteil
Copy link
Contributor

@techalchemy / @fridex I think this PR can be closed now we have 2018.10.9 🎉

@fridex fridex closed this Oct 9, 2018
@fridex fridex deleted the pip-18.1-workaround branch October 9, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip 18.1 causes "TypeError: 'module' object is not callable"
5 participants