Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add spinner during locking #2993

Closed
wants to merge 6 commits into from
Closed

Conversation

techalchemy
Copy link
Member

Signed-off-by: Dan Ryan [email protected]

pipenv/core.py Outdated
@@ -1344,7 +1345,8 @@ def pip_install(
index_source = index_source.copy()
except SourceNotFound:
src_name = project.src_name_from_url(index)
verify_ssl = True if index not in trusted_hosts else False
index_url = parse_url(index)
verify_ssl = True if index_url.host not in trusted_hosts else False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the following form is enough:

verify_ssl = index_url.host not in trusted_hosts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it is! thanks for the feedback :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigger fish to fry on this one -- VCS installs are throwing permissions errors :(

pipenv/core.py Outdated
@@ -1355,7 +1357,8 @@ def pip_install(
extra_src = project.find_source(idx)
except SourceNotFound:
src_name = project.src_name_from_url(idx)
verify_ssl = True if idx not in trusted_hosts else False
src_url = parse_url(idx)
verify_ssl = True if src_url.host not in trusted_hosts else False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify_ssl = src_url.host not in trusted_hosts

- Update vendored deps
- Fix minor bugs

Signed-off-by: Dan Ryan <[email protected]>
@techalchemy techalchemy changed the title Add spinner during locking WIP: Add spinner during locking Oct 11, 2018
@techalchemy
Copy link
Member Author

Closing, I have a better implementation of this

@frostming frostming deleted the add-locking-spinner branch November 5, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants