Issue 4993 Add standard pre commit hooks and apply linting. #4994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how pip has pre-commit configuration: https:/pypa/pip/blob/main/.pre-commit-config.yaml
This adds the configuration, applies it using
pre-commit run --all-files --verbose
and like usual there are a few flake8 things that had to be manually applied, but 99% of this was applied automatically by the linting tools. Also updates the .github action to have a component to check thepre-commit run --all-files
doesn't have errors.TODO:
pre-commit install
orpip install pre-commit
if that is missing)The issue
#4993
The fix
Follows the standards of the pip project, but customized for excluding our vendor and patched directories. Updated to the latest package versions of the pre-commit hooks packages.
The checklist
news/
directory to describe this fix with the extension.bugfix
,.feature
,.behavior
,.doc
..vendor
. or.trivial
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.