Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More vistir dropping #5078

Merged
merged 7 commits into from
Apr 25, 2022
Merged

More vistir dropping #5078

merged 7 commits into from
Apr 25, 2022

Commits on Apr 23, 2022

  1. Replace vistir.compat.NamedTemporaryFile with STL

    NamedTemporaryFile was introduced in Python 3.4.
    We only support Python 3.7+, hence this goes away.
    oz123 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    2bb915e View commit details
    Browse the repository at this point in the history
  2. Removed vistir.compat.Mapping for collections.abc

    Earlier versions of Python had Mapping in ``collections``. All versions
    after 3.4 moved Mapping to ``collections.abc``
    Since we only support version 3.7+ we can drop this.
    oz123 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    640d70d View commit details
    Browse the repository at this point in the history
  3. Remove pipenv.vendor.vistir.compat.Path

    pathlib was introduced after Python3.5. We now only
    support Python3.7+, hence we don't need compat here.
    oz123 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    c8bb3fe View commit details
    Browse the repository at this point in the history
  4. Remove vistir.misc.dedup

    This function is a nice to have alias for one line of code.
    Also, it uses OrderedDict, which is no longer needed. `dict`s after
    Python3.6 are guaranteed to be ordered (bonus: dict is faster than
    ordered dict).
    
    If we really want, we can also import it from zipp or python finder.
    oz123 committed Apr 23, 2022
    Configuration menu
    Copy the full SHA
    1ae2514 View commit details
    Browse the repository at this point in the history
  5. Replace vistir.misc.echo with click.secho

    The former is simply a copy paste of `click.echo`.
    
    Since `click` has a much larger user base, it is likely
    to correct all bugs on all OSes faster.
    oz123 committed Apr 23, 2022
    2 Configuration menu
    Copy the full SHA
    d5fe3fd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f83b4c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2022

  1. Limit resource usage in CI (#5079)

    Fix #5073
    oz123 committed Apr 24, 2022
    Configuration menu
    Copy the full SHA
    fe552a0 View commit details
    Browse the repository at this point in the history