Remove funcsigs as it is only for Python 3.3 and earlier #5168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``funcsigs`` is a backport of the `PEP 362`_ function signature features from Python 3.3's `inspect`_ module. The backport is compatible with Python 2.6, 2.7 as well as 3.3 and up. 3.2 There is only one place which is used in pip-shims, but the execption will never happen on current supported versions of pipenv and Python. https:/sarugaku/pip-shims/blob/d165d55a53065d51aaaebde4124a98c6a8c9fcba/src/pip_shims/utils.py#L387 ``` try: signature = inspect.signature(fn_or_class) except AttributeError: # never reached on python 3.3 or later. import funcsigs ```
|
Thanks for pointing this out @oz123 I created: https:/sarugaku/pip-shims/pull/84/files |
matteius
approved these changes
Jul 8, 2022
|
Can you add a news fragment? If you merge main in you'll get the fix I applied for the windows tests failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
funcsigsis a backport of thePEP 362_ function signature features fromPython 3.3's
inspect_ module. The backport is compatible with Python 2.6, 2.7as well as 3.3 and up. 3.2
There is only one place which is used in pip-shims, but the exception
will never happen on current supported versions of pipenv and Python.
https:/sarugaku/pip-shims/blob/d165d55a53065d51aaaebde4124a98c6a8c9fcba/src/pip_shims/utils.py#L387