Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass real paths when running subprocesses #1168

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Pass real paths when running subprocesses #1168

merged 3 commits into from
Dec 28, 2023

Commits on Dec 28, 2023

  1. Run commands using their real paths 

    Fixes pypa#1164
    @dechamps
    dechamps committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c84e8d2 View commit details
    Browse the repository at this point in the history

  2. Call rmdir with the real path 

    This gets rid of the following warning when using the Microsoft Store
version of Python:

  The system cannot find the path specified.
  Failed to delete C:\Users\etien\AppData\Local\pipx\pipx\trash. You may need to delete it manually.

See also pypa#1164
    @dechamps
    dechamps committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    5a16aac View commit details
    Browse the repository at this point in the history

  3. Use rmtree instead of spawning rmdir on Windows 

    This code dates all the way back to
7cb6561. It's not clear why this code
decides to spawn an rmdir process on Windows instead of simply calling
`shutil.rmtree()` directly.
    @dechamps
    dechamps committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    ac6027a View commit details
    Browse the repository at this point in the history