Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support newer docutils versions #315

Merged
merged 5 commits into from
Jul 1, 2024

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Jun 29, 2024

This PR introduces the following changes, based on feedback in #310:

  • Drop support for Python 3.8

    (Newer docutils releases drop support for Python 3.8 and change how some test files render)

  • Require docutils 0.21.2 or higher

  • Update three HTML test files to match how docutils 0.21.2 now renders the accompanying input files

  • Test all supported CPython and PyPy versions in tox and in CI

  • Remove <s> from the list of allowed HTML tags, now that newer docutils versions don't render that tag anymore

Fixes #310

Note

If this merges, #311 can be closed.

Copy link
Member

@miketheman miketheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is overall looking good, thanks for keeping at it!

tests/fixtures/test_rst_bibtex.html Show resolved Hide resolved
@miketheman miketheman merged commit fefd285 into pypa:main Jul 1, 2024
8 checks passed
@kurtmckee kurtmckee deleted the support-newer-docutils-versions branch July 1, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docutils 0.21.2 breaks the test suite
2 participants