Implement PEP 517 Build Backend #1039

ghost · 2017-05-22T04:03:24Z

This complies with the pep that will probably be adopted in any case, and doesn't break any existing functionality.

ghost · 2017-05-22T04:29:59Z

@jaraco This should be okay to go if the tests pass. It's not bulletproof but pip can always fall back.

jaraco · 2017-05-28T16:42:12Z

Can you provide a link to the pep? Why use py517 instead of pep517?

ghost · 2017-05-31T16:28:40Z

Wow, it looks like it's been accepted.

https://www.python.org/dev/peps/pep-0517/

@jaraco I'll rename the module. I think pip was originally going to have it's own setuptools backend but if we put the backend in the setuptools repository, then pip can just require the latest setuptools by default and then execute the backend according to the standards. In other words, it move all of the monkeypatching and hackery out of pip and into setuptools, where it belongs.

This change brings setuptools into very basic compliance with PEP 517.

ghost · 2017-07-05T18:01:48Z

@ncoghlan Can you specify the additonal concerns for out-of-tree builds?

ghost · 2017-08-05T23:38:26Z

@pfmoore @dstufft

Hello all:

I have been attempting to resolve the horrible easy_install behavior where compiled wheels published on pypi are not used to fulfill setup requirements. To address this issue, I have submitted pull requests to both setuptools and pip that would allow a proprietary communication method that can later be easily adjusted to be fully PEP 517 compliant, saving work while resolving a specific issue.

However, everyone appears to be ignoring these pull requests, in my estimation, because PEP 517 is not fully completed. That’s fine, but partial PEP 517 compliance in one area is better than nothing at all, which is currently the default scenario.

ghost · 2017-08-31T22:09:40Z

So just as a reference we need to use wheel.egg2wheel to convert egg_info to dist_info.

jaraco · 2017-09-03T14:47:25Z

setuptools/dist.py

- self.fetch_build_eggs(attrs['setup_requires'])
+ if skip_install_eggs:
+ raise SetupRequirementsError(attrs['setup_requires'])
+ else:


You don't need the else block here.

jaraco · 2017-09-03T14:52:44Z

setuptools/dist.py

@@ -25,6 +25,14 @@
 from .py36compat import Distribution_parse_config_files


+skip_install_eggs = False


This variable appears to be undocumented and untested. It could be optimized away.

I wonder if instead of setting a global flag that tweaks the inner behavior of the Distribution object for all users if it wouldn't be better for the caller that would use this functionality to instead create a:

class Distribution(setuptools.dist.Distribution): def fetch_build_eggs(self, eggs): raise SetupRequirementsError(...)

It's not yet clear to me where a user or application would hook into this behavior.

Also, the name 'skip_install_eggs' doesn't match the behavior. It's 'fail on install eggs'.

This variable is for internal use only. The public api is get_requires_for_build_wheel

jaraco · 2017-09-03T14:54:31Z

What's the status of this PR? It's still tagged WIP, yet one comment says it's good to go. Other comments still say "we need", suggesting there's more work to be done.

I've added some comments about the implementation. I'm generally fine with new pep517 module, but I'm reluctant to add implicitly-defined hooks that complicate the (already complicated) behavior. I've suggested another possible approach which may prove simpler, but first, I think we need to understand how it is that this behavior is intended to be used.

ghost · 2017-09-03T15:00:13Z

What's the status of this PR? It's still tagged WIP, yet one comment says it's good to go. Other comments still say "we need", suggesting there's more work to be done.

The reason for this is that the PEP was modified after it was initially accepted. It's not currently acceptable to merge. I'm working on the pip side of the chain first and will then update this.

ghost · 2017-09-04T03:23:28Z

@jaraco Let's go ahead and get this in here as the pip people seem to be taking their time.

ghost · 2017-09-04T03:27:46Z

setuptools/dist.py

@@ -25,6 +25,14 @@
 from .py36compat import Distribution_parse_config_files


+_skip_install_eggs = False
+


So again I want to emphasize that this is an internal setuptools implementation detail that should not be used outside of setuptools.

ghost · 2017-09-04T03:29:06Z

setuptools/pep517.py

+def get_requires_for_build_sdist(config_settings=None):
+ config_settings = fix_config(config_settings)
+ return get_build_requires(config_settings)
+


These two get_requires functions are the public API. They will be used by pip to determine the setup requirements.

ghost · 2017-09-04T03:33:34Z

I've suggested another possible approach which may prove simpler, but first, I think we need to understand how it is that this behavior is intended to be used.

I added some tests that should help clarify this matter. Let me know if you have any other questions.

ghost · 2017-09-04T03:35:00Z

setuptools/pep517.py

+def prepare_metadata_for_build_wheel(metadata_directory, config_settings=None):
+ sys.argv = sys.argv[:1] + ['dist_info', '--egg-base', metadata_directory]
+ _run_setup()
+


This will start working once pypa/wheel#190 is merged but there is no need to wait for that.

ghost mentioned this pull request Jun 5, 2017

allow specification of build-time dependencies on egg_info invokation pypa/pip#4465

Closed

xoviat added 2 commits June 5, 2017 22:02

pep517: add module

28eef1e

This change brings setuptools into very basic compliance with PEP 517.

tests: fire travis

c4b0389

ghost mentioned this pull request Jul 1, 2017

Partially implement PEP 517 pypa/pip#4589

Closed

xoviat added 2 commits August 5, 2017 18:37

fire-ci

fb5df4e

fire-ci

2911c9f

xoviat added 3 commits August 19, 2017 17:16

pep517: add setuptools_implementation_revision

65ac1ca

pep517: implement get_build_requires modifications

5b8aceb

pep517: Update signatures

f1a3e2b

ghost changed the title ~~py517: implement get_build_requires~~ Wip: py517: implement get_build_requires Aug 24, 2017

ghost changed the title ~~Wip: py517: implement get_build_requires~~ WIP: implement PEP 517 Build Backend Aug 25, 2017

xoviat added 5 commits August 24, 2017 20:58

pep517: implement clean directory

95ce0cf

pep517: implement directories to copy

76888ab

pep517: repair syntax error

7079a47

pep517: fix list comprehension

cca9ed3

pep517: implement absolute paths

5f322bd

jaraco reviewed Sep 3, 2017

View reviewed changes

xoviat added 4 commits September 3, 2017 20:28

pep517: add prepare_metadata_for_build_wheel

5db94ea

tests: begin build frontend emulation

ea08d17

pep517: implement build backend fixture

3427921

pep517: test get_requires_for_build_wheel

d2270e7

tests: add build_wheel and build_sdist

ea77313

ghost changed the title ~~WIP: implement PEP 517 Build Backend~~ Implement PEP 517 Build Backend Sep 4, 2017

xoviat added 2 commits September 3, 2017 22:25

dist: rename skip install eggs to be private.

0d8ee1f

pep517: rename skip_install_eggs

93f5fe2

ghost commented Sep 4, 2017

View reviewed changes

ghost mentioned this pull request Sep 4, 2017

dist_info: implement command pypa/wheel#190

Closed

ghost closed this Sep 8, 2017

ghost deleted the py517 branch September 8, 2017 02:42

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement PEP 517 Build Backend #1039

Implement PEP 517 Build Backend #1039

ghost commented May 22, 2017

ghost commented May 22, 2017

jaraco commented May 28, 2017

ghost commented May 31, 2017

ghost commented Jul 5, 2017

ghost commented Aug 5, 2017 •

edited by ghost

Loading

ghost commented Aug 31, 2017

jaraco Sep 3, 2017

jaraco Sep 3, 2017

ghost Sep 3, 2017

jaraco commented Sep 3, 2017

ghost commented Sep 3, 2017

ghost commented Sep 4, 2017

ghost Sep 4, 2017

ghost Sep 4, 2017

ghost commented Sep 4, 2017

ghost Sep 4, 2017

		@@ -25,6 +25,14 @@
		from .py36compat import Distribution_parse_config_files


		skip_install_eggs = False

		@@ -25,6 +25,14 @@
		from .py36compat import Distribution_parse_config_files


		_skip_install_eggs = False

Implement PEP 517 Build Backend #1039

Implement PEP 517 Build Backend #1039

Conversation

ghost commented May 22, 2017

ghost commented May 22, 2017

jaraco commented May 28, 2017

ghost commented May 31, 2017

ghost commented Jul 5, 2017

ghost commented Aug 5, 2017 • edited by ghost Loading

ghost commented Aug 31, 2017

jaraco Sep 3, 2017

Choose a reason for hiding this comment

jaraco Sep 3, 2017

Choose a reason for hiding this comment

ghost Sep 3, 2017

Choose a reason for hiding this comment

jaraco commented Sep 3, 2017

ghost commented Sep 3, 2017

ghost commented Sep 4, 2017

ghost Sep 4, 2017

Choose a reason for hiding this comment

ghost Sep 4, 2017

Choose a reason for hiding this comment

ghost commented Sep 4, 2017

ghost Sep 4, 2017

Choose a reason for hiding this comment

ghost commented Aug 5, 2017 •

edited by ghost

Loading