Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable McCabe complexity check in flake8 #2518

Merged
merged 13 commits into from
Jan 16, 2021

Conversation

webknjaz
Copy link
Member

Summary of changes

flake8 can check code for complexity, it's the best practice to enable it.
This change makes sure to gate overly complex code guiding the contributors
to make it simpler when necessary.

It also disables the check in some places while fixing the others. I've only
simplified things that are easy to address and those changes can be easily
cherry-picked separately.

Ref: jaraco/skeleton#34

Pull Request Checklist

@webknjaz webknjaz force-pushed the maintenance/flake8-mccabe-complexity branch from e3a1d93 to 4a02c8e Compare December 31, 2020 17:39
@webknjaz webknjaz force-pushed the maintenance/flake8-mccabe-complexity branch from 4a02c8e to 6f74941 Compare December 31, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants