Merge latest skeleton #4211
Merged
Merge latest skeleton #4211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd their presence blocks the names of packages like 'builder' and 'distutils'. Ref pypa/distutils#224.
* Tweak coverage configuration for type checking * Use `exclude_also` instead of `exclude_lines` Co-authored-by: Sviatoslav Sydorenko <[email protected]> * Add reference to the issue. --------- Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Jason R. Coombs <[email protected]>
Reformatted with ruff v0.2.0.
Reformatted with ruff 0.2.1.
eli-schwartz
added a commit
to eli-schwartz/gentoo
that referenced
this pull request
Mar 13, 2024
In the latest version of setuptools, setuptools stopped explicitly excluding the build/ directory: pypa/setuptools#4211 It is the default build_base until we specially set it via $DIST_EXTRA_CONFIG -- and before then, by rm -rf'ing the build/ directory. Both approaches were guarded by checking if DISTUTILS_USE_PEP517 is set to setuptools. This doesn't work for the setuptools package itself, since setuptools builds "standalone" so that it can depend on its own in-tree backend. Result: setuptools has always been ignoring BUILD_DIR and leaving persistent files around. Somehow that led to the new version of setuptools without `options.packages.find -> exclude = build`, installing a bunch of new files when building for multiple PYTHON_COMPAT targets. From iwdevtools: * FILES:+usr/lib/python3.12/site-packages/build/lib/setuptools/wheel.py [...] * SIZE: 13.88MiB -> 20.44MiB, 1083 -> 1631 files * ------> FILES(+556,-8) SIZE(+47.22%) (It should be noted that as part of the upgrade itself, python3_11 did get +12,-4 files, which is vastly out of proportion to the combined total of 556. This should actually be +24,-8.) Fix by running setuptools based code for standalone build-backends (and pbr, a setuptools wrapper) as well. It is either unneeded or necessary, but shouldn't hurt. Signed-off-by: Eli Schwartz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Closes
Pull Request Checklist
newsfragments/.(See documentation for details)